Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WCAG 2.0 #32

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Support WCAG 2.0 #32

merged 2 commits into from
Jan 25, 2022

Conversation

cartertemm
Copy link
Contributor

Despite the widespread adoption of WCAG 2.1 and it's seventeen additional success criterion, many governments and agencies continue to rely on 2.0 as a standard. This PR makes it possible to include targetWcagVersion: "2.0" in index.njk front matter.

@hidde
Copy link
Owner

hidde commented Jan 25, 2022

Thank you, this is great! Would you be able to add WCAG 2.0 support to the Supported languages table in the README?

const totals = totalsperLevel[targetWcagVersion][targetLevel];

// use string representation of WCAG version to avoid unwanted conversion from e.g. 2.0 to index 2
const totals = totalsperLevel[targetWcagVersion.toString()][targetLevel];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cartertemm
Copy link
Contributor Author

Good catch. I've made the requested improvements (hopefully) in a satisfactory format.

@hidde
Copy link
Owner

hidde commented Jan 25, 2022

Thanks a lot @cartertemm !

@hidde hidde merged commit 1760350 into hidde:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants